Emoncms 9.7.3 can't clone dashboard + toggle published problem

joyrider3774 · 30 September 2016 22:37

Hey,

I’m on latest dev and just did a pull on master as well as on dashboard module. There seems to be a problem with the list of dashboards. For one thing when i click on the random icon for cloning a dashboard nothing seems to happen except that it seems to “enable” the publish icon in that row but no dashboard seems to be cloned. Also clicking / toggling the publish icon has no effect. Once the dashboard is toggeld as published it won’t unpublish even though the icon changes the dashboard remains published and i have no way to undo this.

I have been trying to look in the code to see whats wrong but not much luck figuring it out.

Just posting to see if anyone else has this problem ?

I’m running a locally hosted emoncms

joyrider3774 · 1 October 2016 07:28

i figured it out, it’s a bug in the cloning system.

the name column in the dashboar table is varchar(30) so max 30 characters, in the dashboardclone function in dashboard_model.php. the name is taken from the current dashboard and " clone" is added BUT there is no verification if the name for the dashboard does not exceed 30 characters. So if your original dashboard name is 30,29,28,27,26 or 25 characters the cloning of the dashboard fails because the sql statement fails with following error #1406 - Data too long for column 'name' at row 1. the culprit is this line dashboard/dashboard_model.php at master · emoncms/dashboard · GitHub

my original dashboard name was “Smart plug6 Microgolf oven” which are 26 characters the cloned dashboard name would become “Smart plug6 Microgolf oven clone” which are 32 characters and is bigger than what the name column is in the database !

i’ll create an issue about this on github

workaround is to temperary rename the original dashboard to a name that has 24 or lower characters

joyrider3774 · 1 October 2016 08:45

also found a way to fix the values of published and public not updating for my version. For some reason it tried to set empty values to those fields in the database when the values where false with me (like update … set `published`= ‘’) and i got sql error ‘’ is not a valid integer value).

In my local version i changed the code a bit so it became what i wrote in this issue but i’m still not sure if i was the only one with this problem somehow ?

joyrider3774 · 3 October 2016 17:18

guys all the issues (even the clone dashboard one) are all due to this
https://www.euperia.com/development/mysql-fix-field-doesnt-default-value/1509 which @nchaveiro pointed out.

If i disable strict mode (which is on by default on mysql 5.7) all the issues are resolved …

for windows users using the latest wamp version , you can disable strict mode by clicking on the wamp system tray icon then choose mysql → my sql settings → sql mode → none

it will write the value from the above url in your mysql my.ini config file then and restart all services, solving all these problems with default code

nchaveiro · 3 October 2016 20:53

Well spotted!

joyrider3774 · 4 October 2016 09:50

@TrystanLea i changed the solution to using Non strict mode for mysql, if strict mode is enabled emoncms has a few other problems as well. In strict mode the sql code for the clonining of the dashboard fails because the cloned dashboards name is bigger then the fields name however in none strict mode mysql just removes the extra characters an happily executes the sql statement without a problem. So solution is actually to disable strict mode not just the temporary work around of renaming the dashboard as that would not solve the other problems …

These github issues i made all had the same solution → disabling strict mode:

github.com/emoncms/emoncms

Can't add new feeds based on inputs (master branch)

opened 06:56PM - 27 Sep 16 UTC

closed 12:00PM - 03 Oct 16 UTC

joyrider3774

Hi, yesterday i installed the master branch of emoncms, i'm not certain where to… go for issues but one thing i noticed is that i can't add new feeds anymore that i base upon an input node. just selecting an input node and chosing "log to feed" gives me the error "SQL returned invalid insert feed id". i traced it down in the code and what i think is happening is that when i click on the add button to add the feed `'create':function(tag, name, datatype, engine, options)` is called in `feed.js` which calls feeds.json which calls `public function create($userid,$tag,$name,$datatype,$engine,$options_in)` in `feed_model.php` and the sql statement (`$result = $this->mysqli->query("INSERT INTO feeds (userid,tag,name,datatype,public,engine) VALUES ('$userid','$tag','$name','$datatype',false,'$engine')");` ) this sql statement fails for me giving me this error: ``` SQL-query: INSERT INTO feeds (userid,tag,name,datatype,public,engine) VALUES ('1','Node 19','node:19:sensor.emoncms1_feedid_29','1',false,'5') MySQL meldt: Documentatie #1364 - Field 'processList' doesn't have a default value ``` The problem is that in `feed_schema.php` there is a column defined `'processList' => array('type' => 'text')` yet this value is never set in the above sql statement and if i look into my phpmyadmin `processlist` had no default value set. changing the defintion to add a default value or say Null is acceptable in `feed_model.php` for processlist did not solve my problem as the database check & update kept saying the database is up to date. i had to manually change the default value to null in my emoncms database using phpmyadmin once i specified the default value as being null i could create / save the processlist. then sending a test value to the input where the feed is based on worked again (i used mqtt to send the value using old mqtt input listener). as i don't know if this is related to issue #541 or if this is a real issue / bug with the master branch, or a problem with my local installation / update i did yesterday. I thought i'd just mention this here and perhaps someone can look into my findings and decide if this a bug of some kind or some problem with updating i was actually looking into #541 to see if i had the same problem with the old input listener (which it seems i don't) the processlist is related to virtual feeds, but i don't know if it needs a default value of null and / or something needs to be added in the processlist definition in `feed_model.php`or not.

github.com/emoncms/dashboard

published and public values don't seem to save anymore with me

opened 08:42AM - 01 Oct 16 UTC

closed 04:41PM - 03 Oct 16 UTC

joyrider3774

Hi, i'm on latest pull of both this repo as well as emoncms. I noticed when you… are in the dashboard list and you click on the icon's of either published or public the icon changes but the data is not saved for some reason. The sql statement failed when the value was false but not when it was true. i could check this by clicking on the publish icon of a dashbard that was already published, it showed the not published icon but if i refreshed the page the dashboard was still public. i checked the sql statement and when it was having a value of false i tried to do set `published`= '' which gives the sql error '' is not a valid integer value. i was able to fix it in my local version by changing those [3 lines](https://github.com/emoncms/dashboard/blob/master/dashboard_model.php#L134) to this below so that it "hard" returns 1 or 0 without quotes (so sql sees it as an integer) and explicity setting 0 solved it somehow for me ``` if (isset($fields->public)) $array[] = "`public` = ". (((bool)$fields->public) ? "1":"0") .""; if (isset($fields->published)) $array[] = "`published` = ".(((bool)$fields->published) ? "1":"0") .""; if (isset($fields->showdescription)) $array[] = "`showdescription` = ".(((bool)$fields->showdescription) ? "1":"0").""; ``` now everything works again for me

github.com/emoncms/dashboard

cloning of dashboards fail if orignal dashboard name is bigger then 24 characters

opened 07:33AM - 01 Oct 16 UTC

closed 05:19PM - 03 Oct 16 UTC

joyrider3774

the cloning of dashboards fail if orignal dashboard name is bigger then 24 chara…cters because of this line here : https://github.com/emoncms/dashboard/blob/master/dashboard_model.php#L52 it doesn't take into account the max length of the name column (which currently is 30) in the database and just blindly adds " clone" to the name. so if your dashboard name is greater then 24 characters for example as in my case 26 characters from "Smart plug6 Microgolf oven" the insert sql statement fails with `Data too long for column 'name' at row 1`. not sure how to solve it but perhaps the original name can be shortened if the orignal name exceeds max size - 6 characters (" clone" is 6 characters).

and i’m pretty certain this one has probably the same cause