How to contribute code?

Emoncms Development
1

I wanted to create a pull request for a bug, and wondering what process you are using. I know git. Are people creating a fork, and pushing there? Do you need to request privileges to create new branches in the project? If there is a doc, sorry, I missed it, please direct me to it.

The specific issue is this recent commit: Added CS Solar Kit device & cleaned up split phase meter device by CircuitSetup · Pull Request #48 · emoncms/device · GitHub where the JSON is not valid in the solar file. It needs a couple of commas.

1 Like
2

I tend to take a fork of the repo. Create a branch - make changes - commit/push to your fork and then do the PR from there to the master branch on upstream.

If it is a small change I often just edit directly on GitHub and do the PR from there.

2 Likes