Heat Pump Experimentation App - Release News

MyForest · 3 July 2022 14:51

It’s this line:

MyForest/mmspheatpump/blob/f461e17bbe16abb3344da7e75019385f6af20d6b/mmspheatpump.php#L251


      
          // Inject the server-stored configuration for this app into the web page so it can use the feed configuration the end-user set up
          
          // For example, this code might look like this on the client-side if there's a feed mapped by the user:    config.db = {"FlowTemperature":"505"};
          
          // This is incredibly risky. All sorts of things in the content could scupper us
          // For example a single quote
          try{
              config.db =JSON.parse('<?php echo json_encode($config); ?>');
          }catch{
              app_log("Error","Unable to load your settings, using the defaults")
              config.db={}
          }
          
          
          // Use the application name from the server-side
          config.name = "<?php echo $name; ?>";
          
          // Make it easier to find the application in users task manager
          document.title=config.name + " - " + document.title;
          
          // Use setTimeout so we can jump into the async world

Which confusingly is not line 526 in the source. When you view the page source in your broken (or fixed) app you’ll see it appears on line 526. A load of script is getting injected that is altering the line number at runtime.

When moving from v10 to v11 @Timbones and I added an approach to get the config from both places to make the code cross-version.

It looks as though appconf.js wasn’t being loaded from anywhere for you. It’s ironic that it was crashing in the error handler. Just to help improve things in the future, didn’t you get an error dialog from this line of code:

app_log(“Error”,“Unable to load your settings, using the defaults”)

The comment on (source) line 245 warns that loading the config into the Javascript and then parsing it at runtime is incredibly risky. It’s not helped by my app_log not including any information about the error.

So I’m not quite sure how you ended up with a version that didn’t work at all. I can only conclude at the moment that the lack of a config JSON caused it to get upset and then stay upset.

MyForest