Error after update to V9.8.28

I made a update from V9.8.7 to V9.8.28

Now i got the follow error message at the administrators page

Warning: Invalid argument supplied for foreach() in /var/www/vhosts/xxx-xxxx.eu/httpdocs/Modules/admin/admin_main_view.php on line 306

Everything seems to be working.

Kind Regards
Gregor

Server Information
Emoncms Version 9.8.28 : 2018.01.27
Modules Administration : Dashboard v1.1.1 : EventProcesses : Feed : Graph v1.2.0 : Input : CoreProcess : Schedule : Time : User : Visualisation
Server OS Linux 3.16.0-5-amd64
Host xxx.xxxxxx.eu xxx.xxxxxx.eu (127.0.0.1)
Date 2018-02-20 06:41:00 UTC
Uptime 07:41:00 up 41 days, 12:42, 0 users, load average: 1.14, 1.26, 1.27
HTTP Server Apache HTTP/1.0 CGI/1.1 443
MySQL Version 5.5.5-10.0.32-MariaDB-0+deb8u1
Host localhost (127.0.0.1)
Date 2018-02-20 07:41:00 (UTC 01:00‌​)
Stats Uptime: 332583 Threads: 3 Questions: 28701499 Slow queries: 83 Opens: 204613 Flush tables: 1 Open tables: 9000 Queries per second avg: 86.298
Disk Mount Stats
/ Used: 52.10% Total: 1.11 TB Used: 594.78 GB Free: 488.87 GB
PHP Version 7.1.14 (Zend Version 3.1.0)
Modules bcmath v7.1.14 : bz2 v7.1.14 : calendar v7.1.14 : cgi-fcgi : Core v7.1.14 : ctype v7.1.14 : curl v7.1.14 : date v7.1.14 : dba v7.1.14 : dom v20031129 : enchant v7.1.14 : exif v7.1.14 : fileinfo v1.0.5 : filter v7.1.14 : ftp v7.1.14 : gd v7.1.14 : gettext v7.1.14 : gmp v7.1.14 : hash v1.0 : iconv v7.1.14 : imagick v3.4.3RC1 : imap v7.1.14 : intl v1.1.0 : ionCube Loader : json v1.5.0 : ldap v7.1.14 : libxml v7.1.14 : mbstring v7.1.14 : mcrypt v7.1.14 : mysqli v7.1.14 : mysqlnd : odbc v7.1.14 : openssl v7.1.14 : pcre v7.1.14 : PDO v7.1.14 : pdo_mysql v7.1.14 : PDO_ODBC v7.1.14 : pdo_pgsql v7.1.14 : pdo_sqlite v7.1.14 : pgsql v7.1.14 : Phar v2.0.2 : posix v7.1.14 : pspell v7.1.14 : redis v3.0.0 : Reflection v7.1.14 : session v7.1.14 : SimpleXML v7.1.14 : soap v7.1.14 : sockets v7.1.14 : SPL v7.1.14 : sqlite3 v7.1.14 : standard v7.1.14 : sysvmsg v7.1.14 : sysvsem v7.1.14 : sysvshm v7.1.14 : tidy v7.1.14 : tokenizer v7.1.14 : xml v7.1.14 : xmlreader v7.1.14 : xmlrpc v7.1.14 : xmlwriter v7.1.14 : xsl v7.1.14 : Zend OPcache v7.1.14 : zip v1.13.5 : zlib v7.1.14 :

Client Information
HTTP Browser Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Screen Resolution 3840 x 2160
Window Size 3325 x 2023

Thanks @gkobler, looks like the last time that line was changes was about a year ago: https://github.com/emoncms/emoncms/blame/master/Modules/admin/admin_main_view.php#L306

It does look like a reference to an emonSD specific installation as its looking for the file /boot/emonSD-*.
@Paul @glyn.hudson do you have any idea about this line?

It looks like the error is from a commit 7 months back

that PR attempts to fix the errors seen by a non-emonSD raspberry pi setup by moving the emonSD specific code outside the test for a Pi mac address. This however puts the emonSD stuff the path of non-rasperrypi systems.

This appears to be an amd-64 and the lack of “cpu temp” in the sytem stats suggest the test for a pi mac is working fine, it just shouldn’t be looking for a emonSD revision number in the /boot partition if it’s not an emonSD or even a Pi.

I’ve just added a further test to only include the emonpi stuff, if it’s an emonpi.

Paul

2 Likes

Thanks for this. I’ve just tested and @Paul PR works on an emonPi.

1 Like

Fix are working. Thanks @Paul

1 Like

Now merged into the Master branch.

Paul

1 Like