Hi @glyn.hudson,
I’m always up for constructive feedback.
Yep, that’s a good idea. I’ve moved the bottom options and also skip missing/ stacked into “advanced” as follows:
The defaulting to bars was something that I’d noticed and fixed about the time you’d sent this message. And was due to my updates from Codacy suggesting a === and me assuming that ‘datatype’ was stored as a numeric. I’ve converted the comparison to a string to fix this.
I had wondered if we remove the bars option for datatype=1 which I believe covers the ‘power’ style data sources and potentially the “lines with steps” as well, which could mean we just remove that drop down entirely. Otherwise I can think about how to revise the barwidth to support this datatype - What do you think?
As you’ll have seen with the number of additional commits, I somewhat daftly decided to learn more about these coding best practices by following the Codacy advice and have regretted it a little!. The knock on is that I’ve removed a large number of minor misdemeanors, but am left with a lot of Generic Object Injection Sink (security/detect-object-injection), the guidance isn’t clear to me, but believe that there is a concern about code injection possibilities, but am otherwise unsure on what we could actually do here!?
Clive.