Absolutely, I’m not a maintainer of OEM emonhub so I can’t call the shots on what is convention now and I cannot do any documentation as I have no idea of the direction or expected functionality, if we document what is currently coded and how it currently works it would cement the elements that need changing, so at best, could be a wasted effort if changes are made.
I would like to believe that it’s just a case of misunderstanding or being unaware of certain conventions etc but there is plenty of evidence to the contrary.
Here’s an example of me pointing out the same thing before the code was merged/released and yet my post was ignored and no changes made, the code was merged and documented. Now, one could argue it’s too late to make that very small change, but back then there was no reason to run with it.
This is just an example as I said, there are other instances where I’ve pointed this same thing out, and also the underscores, on github as well as here on the forum. But rarely (if ever?) are these comments taken onboard. This isn’t aimed at anyone in particular, just highlighting where improvement could be made.
Maybe there is no longer any convention and I should just not comment, whilst intended as a help, it is probably just seen as moaning and negative criticism.