Hi All, I was digging through emonhub code for an unrelated issue and found this in emonhub_setup.py # Check settings only once per second (could be extended if processing power is scarce) now = time.time() if now - self._settings_update_timestamp < 1: return …

Could the check just look at the last modified time of the config file? Keep track of the last modified time of the file when the config was last read… if the modified time has changed, re-parse the file and update the “last parsed file modified timestamp” variable.

[image] Greebo: Could the check just look at the last modified time of the config file? That sounds like a good scheme. Would you mind suggesting some code to do so?

Just pushed some changes that add an option to increase the reload interval. @Greebo your suggestion might be better! Add in option to extend the reload interval openenergymonitor:master ← borpin:patch-9 …

[image] borpin: @Greebo your suggestion might be better! I think so too - surely there’s a OS API call to get the file details which include creation and modification times? Reading and parsing the file reads more like a sledgehammer & nut solution to me.

I didn’t say it was a good solution, just a solution. And this feature (reloading settings) has been here since it’s inception I think.

Interesting, but it still defaults to 1 second. Could we put a less aggressive figure in as default ? I’m still for stopping the behaviour altogether as I think it’s bad practice, and if we look at other projects (eg apache, dnsmasq… in fact most) the behaviour is not to reload unless told… and I’…

[image] alandpearson: Could we put a less aggressive figure in as default ? No, as this way it isn’t a breaking change.

[image] Robert.Wall: I think so too - surely there’s a OS API call to get the file details which include creation and modification times? Reading and parsing the file reads more like a sledgehammer & nut solution to me. Yep, the logic is fairly simple, the procedure calls are simple and I tho…

[image] alandpearson: I’d argue that’s what users expect. Probably - the ones who haven’t noticed that it reloads anyway. But for those that have and have come to rely on it, as Brian says it’s a breaking change, and we’re the ones who have to supply the answers on the forum.

[image] alandpearson: Interesting, but it still defaults to 1 second. Could we put a less aggressive figure in as default ? Or maybe leave the default as-is but add a switch that allows you to change the behaviour to suite your needs? [image] alandpearson: I’m still for stopping the beh…

Community

OpenEnergyMonitor

OpenEnergyMonitor Community

Emonhub - Reduce CPU usage

emonHub

borpin (Brian Orpin) 20 February 2023 07:26 27

That is an old install!