Both of those are correct. However, there’s been a post very recently that I responded to where the user had initially connected a pulse output the other way round and fitted a pull-down resistor, which was competing - and they experienced noise in the c.t’s current reading. They changed it round, but had a quite long cable and adding a second pull-up in parallel with the internal, quite weak one, all the noise problems seem to have gone away. (Water meter pulse input causes CT noise on emonPi - #3 by igglebop)
So if you have a short cable run, what you have done should be fine. But if you get spurious pulses, then consider adding an external pull-up.