Can I tag a feature request to this thread? I thought it would be good to show the additional emoncms-modules installed, We have the PHP modules shown but not emoncms. It would be easy to simply list the content of the emoncms/Modules folder, but it would be nicer to either show only the additiona…

PR submitted - please make sure that this does what you want (more information in the PR) and that its tested on Windows servers - since its all written in PHP it should work perfectly on Windows also.

Andy I entered this command to grab the update for emoncms modules: git pull https://github.com/AndyTaylorTweet/emoncms.git master but I see this error: Modules Notice: Undefined variable: emoncms_modules in /var/www/emoncms/Modules/admin/admin_main_view.php on line 247 [image] EDIT: did…

Not sure how I managed that but I managed to miss a line of code out in my code I checked into GIT. Have another try.

Now merged into the master git branch. Although it should work fine in Windows as it’s written in PHP, we haven’t been able to test on that platform (I only deleted a Windows test install last night!!!) Could a Windows user please confirm Paul [image]

[image] Paul: Could a Windows user please confirm works fine in windows as well although i don’t have redis so it isn’t displaying buffer / writer due to that i guess [image]

Thanks for the speedy turnaround, I wasn’t expecting that. I hope don’t mind, I have made a couple of changes after pulling in your changes, I have made all “Additionally installed Modules” bold as they are optional and most likely the focus of any interest in this info, one would hope the core mod…

@pb66 - well this is what happens when you share a good idea… Speaking of sharing, you want to share your changes? This was your idea after all, maybe we should look to include your version rather than mine…

For speed (and lack of php skills) I’m afraid I just hacked your code to fit, here’s the diff. I am only too happy to share, but it isn’t up to PR grade and wanted your thoughts before suggesting changes to what you submitted. diff --git a/Modules/admin/admin_main_view.php b/Modules/admin/admin_mai…

So the question is - how do we want this to work… I use the bone stock setup, since it does all I want, so I don’t have any modules installed - I guess what we need is some feed back from everyone about what exactly they want to show here; Every folder with a .git Every Folder What should be bol…

about .git folders what happens if users use the download function on github and not git checkout ? are .git folders included as well then ? I’m guessing that they are not in the repo so it will only display the modules if users used git to get emoncms and their (optional) modules and not when using…

Community

OpenEnergyMonitor

OpenEnergyMonitor Community

Admin display currently installed Emoncms modules

Emoncms