emonSDexpand

NWItaly · 2023-10-20T21:14:25.775Z

Hi, I would like to suggest a small change.

echo " SD card total disk size = "$(python -c "print**(**$PART_END * 512.0 / 1073741824**)**")"Gb"

echo " Data Partition size     = "$(python -c "print**(**($DATA_END - $DATA_START + 1) * 512.0 / 1073741824**)**")"Gb"

I read this post on stackoverflow What does "SyntaxError: Missing parentheses in call to 'print'" mean in Python? - Stack Overflow

borpin · 2023-10-21T12:57:15.982Z

Hi welcome.

Best to add this as a change on GitHub and say why

NWItaly · 2023-10-21T20:57:52.596Z

Sorry, yesterday was very late and today too.
Yesterday I downloaded new emonSD image and I flashed it in a 32GB micro SD for a raspberry 2.
When I tried to execute emonSDexpand I received this message:

SyntaxError: Missing parentheses in call to 'print'

or similar. I don’t have an exact copy of error.
So I tried to modify emonSDexpand script. I finded 2 rows that use “print”. I added 2 parenthesis and bug was solved.

Now I notice that my previous post not show which is the solution.

echo " SD card total disk size = "$(python -c "print $PART_END * 512.0 / 1073741824")"Gb"
echo " Data Partition size     = "$(python -c "print ($DATA_END - $DATA_START + 1) * 512.0 / 1073741824")"Gb"

Resolved:

echo " SD card total disk size = "$(python -c "print($PART_END * 512.0 / 1073741824)")"Gb"
echo " Data Partition size     = "$(python -c "print(($DATA_END - $DATA_START + 1) * 512.0 / 1073741824)")"Gb"

I searched script on GitHub but I didn’t find it.

borpin · 2023-10-22T11:49:57.173Z

NWItaly:

I searched script on GitHub but I didn’t find it

Took me a while to find it.

github.com

emoncms/usefulscripts/blob/b85f71e09cf6f49bef919d1b5012691c3059a0b6/sdpart/sdpart_imagefile#L67-L68


      
          echo " SD card total disk size = "$(python -c "print $PART_END * 512.0 / 1073741824")"Gb"
          echo " Data Partition size     = "$(python -c "print ($DATA_END - $DATA_START + 1) * 512.0 / 1073741824")"Gb"

I’m astonished this still works TBH.

Another pre Python3 script.

NWItaly · 2023-10-22T19:33:35.872Z

Well, now what can I do? I don’t know how to require a changed. I have to open an Issue?

borpin · 2023-10-22T21:07:15.930Z

That is the simplest way.

Once you made the change did it work?

Just to note, by making the change, future updates may get blocked by git. You need to review the update log to check there are no errors after you have updated.