Emoncms v10.2.1 New MQTT Topic Filter Issue

borpin · 2020-03-27T17:14:08.249Z

Improved MQTT topic filter

Might this be a breaking change?

TrystanLea · 2020-03-27T22:13:35.463Z

I dont think its a breaking change, but may cause new inputs to appear for some users posting MQTT data with extended topic strings. Whereas previously these inputs would have been conflated together into a non functional input.

borpin · 2020-03-29T19:52:41.119Z

TrystanLea:

I dont think its a breaking change,

@TrystanLea It is…

Pre update

image1197×49 2.58 KB

Post update

image1190×49 1.6 KB

Bugger.

The old mechanism simply discarded the topics below a certain level!

[edit]
These topics

are no longer received…

image1056×180 4.46 KB

TrystanLea · 2020-03-30T11:51:15.044Z

Hello @borpin

Not so fast then!

A quick script to test here suggests that those topics should work:

import time
import paho.mqtt.client as mqtt

mqttc = mqtt.Client("topic_test")
mqttc.username_pw_set("emonpi", "emonpimqtt2016")
mqttc.connect("192.168.1.64", 1883, 60)
mqttc.loop_start()
while 1:
    mqttc.publish("emon/xiaomi4c:65:a8:d8:de:98/battery",3.3,2)
    mqttc.publish("emon/xiaomi4c:65:a8:d8:de:98/humidity",56.6,2)
    mqttc.publish("emon/xiaomi4c:65:a8:d8:de:98/temperature",19.6,2)
    print "."
    time.sleep(10)

mqttc.loop_stop()
mqttc.disconnect()

I wonder what the difference is between your system and mine?

borpin · 2020-03-30T13:00:07.729Z

Never make 2 changes at once - Apologies, @TrystanLea entirely my fault. this one.

borpin · 2020-03-30T13:01:49.951Z

But the additional _state in the Input name is a breaking change. I think the additional topic levels must have been discarded before.

TrystanLea · 2020-03-30T13:09:32.267Z

Good to hear its working!

borpin:

I think the additional topic levels must have been discarded before.

yes i think that was the case. If you would have had two similar topics one /state and another /value they would have written on top of each other… are you happy with the steps required to remap this new input?

borpin · 2020-03-30T13:28:03.688Z

TrystanLea:

are you happy with the steps required to remap this new input?

Yes but it should be highlighted as a breaking change. In my case there was only one topic so it was not overwritten (though that had happened before).

The idea is sound but I think should have had an attached setting to enable/disable it to avoid it being a breaking change.