Editrealtime vizualisation

alexandrecuer · 17 December 2018 12:34

Hi everybody
I am using EmonCMS version 9.9.4 on a PI3 and the editrealtime vizualisation is not working…

I have tried to delete data in the window, just to test

the console show an error in modules/vis/editrealtime.php
it says typeError: $(...).modal is not a function

 $('#delete-button').click(function () {
    $('#myModal').modal('show');
  });

Edit : the bootstrap modal appears when I choose the full screen mode
Anyway, I cannot delete the datas in the window…
I’ve seen it goes through a json request
http://your_emoncms_ip/emoncms/feed/deletedatarange.json?&apikey=your_api_key&id=32&start=1544756356&end=1544770496
But when I launch manually the request, the API returns false

I’ve searched through the github repository, with the keywork deletedatarange…I am using the PHPFina engine
shouldn’t there be a function deletedatarange in the /Modules/feed/engine/PHPFina.php or is there something I misunderstand ?

Re-edit : I see, This is specific to the MEMORY MYSQL ENGINE (mysqltimeseries)…I guess it is not possible on a timeseries like the one used by PHPFina…

do you have such an error or is it just specific to my setup, and not reproductible from your side ?

Alex

Robert.Wall · 17 December 2018 15:21

If you look at Learn → Electricity Monitoring → Timeseries you will find an explanation of how the data is stored.

This might help your understanding, and why you can only edit, and it is impossible to delete, data in PHPfina files.

alexandrecuer · 17 December 2018 15:47

Thanks Robert, I’ve seen my misunderstanding…
Anyway, do you know if it is possible to replace a window of erronous datas by NaN or 0 eventually ? Actually it was what I was trying to do…and I thougth the delete button was doing this kind of operation…but maybe it is more with “the multiply data in window by”…I will investigate further in the code as I see it may launch a scalerange function…
I’ve tested the update point by point and it is working…
Sorry for the inconvenience.

Robert.Wall · 17 December 2018 16:32

Sorry, but I do not know the details of that part of emonCMS, so I cannot help you.

TrystanLea · 18 December 2018 12:33

Hello @alexandrecuer, the scale and delete features dont currently work in editrealtime. I have a made a note on the emoncms issue list to remove these for now to avoid confusion remove scale and delete options from editrealtime · Issue #1141 · emoncms/emoncms · GitHub

alexandrecuer · 18 December 2018 16:50

OK Thanks Tristan…
I went through the feed controller and model and understood it was not functionnal
Are these things still in your roadmap / postponed to a later date ?
Anyway, I am going to try to do it on my side but I cannot appreciate the complexity right now, as I don’t have a deep knowledge of the PHPFina engine

alexandrecuer · 8 January 2019 16:59

@TrystanLea
I have pushed some pull requests on this matter of scale and edit features, one for the PHPFina Engine and the other for the PHPTimesSeries…could you eventually review them briefly just to check if I am out of scope or not ?

github.com/emoncms/emoncms

datafeed edition for PHPFina engine

emoncms:master ← alexandrecuer:datafeed_edition

opened 04:32PM - 03 Jan 19 UTC

alexandrecuer

+107 -2

This PR makes it functional to edit a datarange of a PHPFINA feed via the editre…altime visualisation : - You can multiply the values in the window by a float or a fraction - You can replace the values in the window by NAN if they are erronous due to some communication problems - You can convert all the values in the window to absolute values cf the following issue : https://github.com/emoncms/emoncms/issues/1141 and this PR : https://github.com/emoncms/emoncms/pull/1142 working only for the PHPFINA engine is it what you were looking for when designing the editrealtime visualisation ? or yu want the process to inject first the data in Redis, the feewriter service being responsible for transferring everything into the feeds ? Alex

github.com/emoncms/emoncms

Update editdaily.php

emoncms:master ← alexandrecuer:PHPTimeSeries_DailyEdition

opened 07:05PM - 05 Jan 19 UTC

alexandrecuer

+1 -1

limitinterval set to 0 when calling the js function get_feed_data(feedID,start,e…nd,interval,skipmissing,limitinterval) in Modules/vis/Modules/vis/visualisations/editdaily.php This permits to correctly perform writes on MYD files with data from the REDIS buffer... with limitinterval equal to 1, the timestamps are slightly different from the timestamps in the.MYD file and the update method of the PHPTimeSeries engine does nothing since the dichotomous algorithm of binarysearch_exact does not converge and always returns -1 when you don't really dive into the code, it is not easy to understand the function of this parameter limitinterval.... in the doc of the get_data($feedid,$start,$end,$interval,$skipmissing,$limitinterval) method of the PHPTimeSeries engine, it is written : > @param integer $limitinterval Limit datapoints returned to this value (used by somes engines) https://github.com/emoncms/emoncms/blob/master/Modules/feed/engine/PHPTimeSeries.php shouldn't the wording be more like that : >@param integer $limitinterval : when set to 1 , return the calculated timestamp if the difference between the calculated timestamp and the timestamp hardcoded of the timeseries datafile is less than $interval when set top 0, return the harcoded timestamp of the timeseries datafile ??

thanking yu by advance
Alex