Cant update EmonCMS via GUI

jamespreedy · 2024-11-04T09:21:16.297Z

I tried the instructions on that thread to change over to python2 in the service-runner.py and service-runner.service.

It didn’t seem to like it that much … so have changed it back.

➜  ~ journalctl -f -u service-runner
Nov 04 09:14:19 emoncms systemd[1]: service-runner.service: Failed with result 'exit-code'.
Nov 04 09:14:49 emoncms systemd[1]: service-runner.service: Scheduled restart job, restart counter is at 5.
Nov 04 09:14:49 emoncms systemd[1]: Stopped Emoncms service-runner Input Script.
Nov 04 09:14:49 emoncms systemd[1]: Started Emoncms service-runner Input Script.
Nov 04 09:14:49 emoncms service-runner[569]:   File "/var/www/emoncms/scripts/services/service-runner/service-runner.py", line 23
Nov 04 09:14:49 emoncms service-runner[569]:     print("Connected to redis server", flush=True)
Nov 04 09:14:49 emoncms service-runner[569]:                                             ^
Nov 04 09:14:49 emoncms service-runner[569]: SyntaxError: invalid syntax
Nov 04 09:14:49 emoncms systemd[1]: service-runner.service: Main process exited, code=exited, status=1/FAILURE
Nov 04 09:14:49 emoncms systemd[1]: service-runner.service: Failed with result 'exit-code'.
Nov 04 09:15:19 emoncms systemd[1]: service-runner.service: Scheduled restart job, restart counter is at 6.
Nov 04 09:15:19 emoncms systemd[1]: Stopped Emoncms service-runner Input Script.
Nov 04 09:15:19 emoncms systemd[1]: Started Emoncms service-runner Input Script.
Nov 04 09:15:19 emoncms service-runner[615]:   File "/var/www/emoncms/scripts/services/service-runner/service-runner.py", line 23
Nov 04 09:15:19 emoncms service-runner[615]:     print("Connected to redis server", flush=True)
Nov 04 09:15:19 emoncms service-runner[615]:                                             ^
Nov 04 09:15:19 emoncms service-runner[615]: SyntaxError: invalid syntax
Nov 04 09:15:19 emoncms systemd[1]: service-runner.service: Main process exited, code=exited, status=1/FAILURE
Nov 04 09:15:19 emoncms systemd[1]: service-runner.service: Failed with result 'exit-code'.
^C```

borpin · 2024-11-04T09:21:43.635Z

Ok, so there is a way to check the command is hitting REDIS, but I can’t remember what it is!

There are 2 parts to REDIS as well (though again it is a while since I played with that) @TrystanLea

IIRC, the button sends a command into a redis buffer which service-runner picks up and actions. We have had issues with this before

borpin · 2024-11-04T09:22:25.289Z

jamespreedy:

I tried the instructions on that thread to change over to python2 in the service-runner.py and service-runner.service.

It is an old thread!

jamespreedy · 2024-11-04T09:23:26.120Z

Yeah, figured it was worth a shot … it wasn’t! haha
Thanks for all your help here though … very much appreciated.

borpin · 2024-11-04T09:51:32.139Z

@Greebo - you did some work on this previously.

I know there is a way to see what is going into Redis, but can’t remember how!

Greebo · 2024-11-04T10:59:58.185Z

I found this thread:

emonPi service-runner now uses redis (core, wifi, sync & postprocess module updates required) Emoncms

Linked post Development Roadmap 2019 - Robust Backup Process - #33 by borpin @Greebo @pb66, digging around in the Redis docs, could you use the SCAN command with a pattern match so it will pick up any prefix? I’m not clear on what the SCAN command returns or how to use it so I am stuck at this point.

Greebo · 2024-11-04T11:18:37.671Z

There’s also L21 and L36 from the service-runner Python script:

github.com

emoncms/emoncms/blob/master/scripts/services/service-runner/service-runner.py#L21


      
          import time
          import shlex
          import redis
          
          KEYS = ["service-runner", "emoncms:service-runner"]
          
          
          def connect_redis():
              while True:
                  try:
                      server = redis.Redis()
                      if server.ping():
                          print("Connected to redis server", flush=True)
                          return server
                  except redis.exceptions.ConnectionError:
                      print("Unable to connect to redis server, sleeping for 30s", flush=True)
                  time.sleep(30)
          
          
          def main():
              print("Starting service-runner", flush=True)

So you could easily put a quick Python script together to check Redis based on that

borpin · 2024-11-04T11:21:19.478Z

Yes I had too, but there were some commands I was shown as to how to watch the redis buffer and see what was being added.

And this Development Roadmap 2019 - Robust Backup Process - #32 by borpin

Ah, found this Multi-instance service-runner - #26 by pb66

There are a couple of redis-cli commands there (you may need to install the cli package).

Greebo · 2024-11-05T02:26:33.567Z

borpin:

Ah, found this Multi-instance service-runner - #26 by pb66

There are a couple of redis-cli commands there (you may need to install the cli package).

Wow, I’d forgotten that whole discussion!

jamespreedy · 2024-11-05T11:41:34.649Z

OK, this is way cleverer than I am - I surrender! haha

Just to check, I appreciate it should be run on a Pi, but is there any Linux distro / version that’s known to work on a VM / Proxmox LXC without issue? I’ve seen a few threads each with what seems like their own lists of things that either work or not.

Thanks for all the help on this thread.

borpin · 2024-11-06T16:19:27.053Z

I’ll have look at some point.

I have a 22.4 install running happily

jamespreedy · 2024-11-06T16:30:18.956Z

Thanks Brian - appreciate the help.
I’ll spin up a new 22.4 LXC and see how I get on.

borpin · 2024-11-06T16:39:29.788Z

I used the Proxmox Helper Scripts for mine.

jamespreedy · 2024-11-06T18:39:03.563Z

Ha, I do too.

I just did a fresh install of 22.04 LXC, just did updates and then used EmonScripts to install.

When going to the Admin/Update GUI page, the Update Log said that /var/log/emoncms/update.log was missing - so I created that with touch, and set the permissions to match a couple of the other logs in there.

➜  emoncms ls -al
total 19
drwxr-xr-x  2 pi   root      5 Nov  6 18:27 .
drwxr-xr-x 12 root syslog   25 Nov  6 18:25 ..
-rw-r--r--  1 root root   2047 Nov  6 18:27 apache2-error.log
-rw-rw-rw-  1 root root   1683 Nov  6 18:31 emoncms.log
-rw-rw-rw-  1 root root      0 Nov  6 18:27 update.log

Anyway, interestingly Full Update, and Update Emoncms don’t seem to do anything on this clean install from the GUI …

borpin · 2024-11-07T07:55:34.389Z

Are all the services running?

borpin · 2024-11-07T08:00:01.573Z

I went back to my install post and noticed I created a user ‘pi’. I think there are some things lurking around that still have this as the hardcoded user

Changes to git stop some commands by the webserver to work Installation

I have just created a new PVE Ubuntu 22.04 LXC in preparation to migrate my current LXC install to a new base OS. I created a use pi and added it to the SUDO users and it all installed fine. The issue is, I am not seeing any of the git info in the admin section After some digging about it seems this is a new ‘feature’ of git. Currently the PiOS version does not seem to be affected as it is still 2.20.2, Ubuntu git version is 2.34.1. I have raised a question on git 2.34.1 dubious ownership e…

jamespreedy · 2024-11-07T08:17:59.692Z

Yeah I learnt the pi mistake first time round when I couldn’t quite make everything work without it. This time aside from root, pi is the only user I created.

I also did a

sudo echo $USER' ALL=(ALL) NOPASSWD: ALL' | sudo tee /etc/sudoers.d/$USER && sudo chmod 0440 /etc/sudoers.d/$USER

per the instructions on here.

I modified config.ini correctly I think and the install seemed to complete ok. I updated everything available with apt.

Services are running … (I need emonhub, but that can come later as I was just testing the update mechanism).

Screenshot 2024-11-07 at 8.13.22 AM1236×762 113 KB

Including redis and service-runner

Screenshot 2024-11-07 at 8.13.52 AM2036×1194 365 KB

Command line update seemed to run fine

/opt/openenergymonitor/EmonScripts/update/service-runner-update.sh all

I feel like I’m missing something really obvious

Thanks again for all your help and suggestions!

reedy · 2024-11-07T19:08:46.047Z

jamespreedy:

I’m having some issues updating using the GUI - “Full Update”, “Update Emoncms” etc buttons don’t seem to do anything.

I note I’m having the same issue too… But using an emonpi!

jamespreedy:

From the CLI, if I run …
/opt/openenergymonitor/EmonScripts/update/service-runner-update.sh all
… then it runs just fine and updates correctly.

Ditto.

reedy · 2024-11-07T19:33:32.818Z

github.com

emoncms/emoncms/blob/8f49021/Modules/admin/admin_model.php#L847C1-L861C6


      
          private function exec($cmd) {
              $output = false;
              if (function_exists("exec")) {
                  $output = @exec($cmd);
              }
              return $output;
          }
          
          private function exec_array($cmd) {
              $output = false;
              if (function_exists("exec")) {
                  @exec($cmd,$output);
              }
              return $output;
          }

I wonder if the @ error suppression is hiding something…

reedy · 2024-11-07T19:39:37.058Z

[Thu Nov 07 19:13:02.390891 2024] [php:error] [pid 832:tid 832] [client 10.13.37.49:51949] PHP Fatal error:  Uncaught Error: Call to private method Admin::runService() from global scope in /var/www/emoncms/Modules/admin/admin_controller.php:221
Stack trace:
#0 /var/www/emoncms/core.php(80): admin_controller()
#1 /var/www/emoncms/index.php(257): controller()
#2 {main}
  thrown in /var/www/emoncms/Modules/admin/admin_controller.php on line 221, referer: http://10.13.37.11/admin/update
[Thu Nov 07 19:37:59.514183 2024] [php:error] [pid 1208:tid 1208] [client 10.13.37.49:56537] PHP Fatal error:  Uncaught Error: Call to private method Admin::runService() from global scope in /var/www/emoncms/Modules/admin/admin_controller.php:221
Stack trace:
#0 /var/www/emoncms/core.php(80): admin_controller()
#1 /var/www/emoncms/index.php(257): controller()
#2 {main}
  thrown in /var/www/emoncms/Modules/admin/admin_controller.php on line 221, referer: http://10.13.37.11/admin/update

@TrystanLea you made the function private, but it’s still seemingly called from elsewhere…

Release 11.6.8 · emoncms/emoncms · GitHub is dated October 25

The prior linked commit is from October 8…

So if you were using master (or similar, rather than releases), that would’ve explained it as you would have had the commit.

EDIT: PR to revert making that private in admin_model.php: Make runService public again by reedy · Pull Request #1904 · emoncms/emoncms · GitHub

Would need a release making, and a manual update on affected devices to bring it in.